Sim Alive Robots Publish #2215
Closed
Sim Alive Robots Publish #2215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ategy/alive_robots) for consistency
| @@ -39,7 +39,7 @@ Radio::Radio() | |||
| } | |||
|
|
|||
| alive_robots_pub_ = | |||
| create_publisher<rj_msgs::msg::AliveRobots>("/alive_robots", rclcpp::QoS(1)); | |||
There was a problem hiding this comment.
For some reason base Radio class (used by network_radio) and sim_radio used different topic names for alive robots. I went with the one used by sim.
sid-parikh
requested changes
Mar 6, 2024
Co-authored-by: Sid Parikh <[email protected]>
|
Code was merged into #2212. @oddlyspookycherry , feel free to leave a review there to ensure your changes were transferred the way you expect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Publish robots 0-6 as alive in
sim_radio.Declare
strategy/alive_robotsas a global topic name for alive robots and make all radios use it.Steps to Test
ros2 topic echo strategy/alive_robots